Skip to content

Conversation

joelanford
Copy link
Member

Description of the change:

pkg/image: fixup containers/image registry test with a test-defined signature policy

Motivation for the change:

This avoids a dependency on the developer CI environment's system/user system policy.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

…ignature policy

This avoids a dependency on the developer CI environment's system/user
system policy.

Signed-off-by: Joe Lanford <[email protected]>
@openshift-ci openshift-ci bot requested review from grokspawn and oceanc80 April 24, 2025 20:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.14%. Comparing base (870588a) to head (506536d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1654      +/-   ##
==========================================
- Coverage   55.16%   55.14%   -0.03%     
==========================================
  Files         136      136              
  Lines       15911    15911              
==========================================
- Hits         8778     8774       -4     
- Misses       5980     5984       +4     
  Partials     1153     1153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 57e74d1 into operator-framework:master Apr 28, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants